source: mod_gnutls/debian/patches/no-deinit-on-proxy-disable.patch @ 8ed8e96

debian/masterdebian/stretch-backportsjessie-backports
Last change on this file since 8ed8e96 was 8ed8e96, checked in by Daniel Kahn Gillmor <dkg@…>, 7 years ago

committing NMU 0.6-1.4 (thanks, Thomas!)
  • Property mode set to 100644
File size: 1.4 KB

  • src/mod_gnutls.c 

    From c782c1f12c0ed4d5048eb52fd3ef51037c53f426 Mon Sep 17 00:00:00 2001
From: Thomas Klute <thomas2.klute@uni-dortmund.de>
Date: Wed, 21 Jan 2015 09:41:51 +0100
Subject: [PATCH] Don't do global deinit when disabling TLS for a proxy back
 end connection

Prior to this commit, ssl_engine_disable called mgs_cleanup_pre_config
on the connection pool before returning:

mgs_cleanup_pre_config(c->pool);

mgs_cleanup_pre_config does not even touch the argument, as its
signature shows.

apr_status_t mgs_cleanup_pre_config(void *data __attribute__((unused)));

It does, however, deinitialize the global session cache and, more
importantly, the global GnuTLS data structures. Trying to use those
deinitialized data structures led to segmentation faults during TLS
handshake.

Since there is no reason to globally deinitialize GnuTLS when disabling
TLS for one specific proxy back end connection, the solution is to
simply remove the call to mgs_cleanup_pre_config from
ssl_engine_disable.
---
 src/mod_gnutls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mod_gnutls.c b/src/mod_gnutls.c
index a77364d..2d0e6ea 100644
    a b int ssl_engine_disable(conn_rec *c) 
    100100        ap_remove_input_filter(c->input_filters);
    101101    if (c->output_filters)
    102102        ap_remove_output_filter(c->output_filters);
    103     mgs_cleanup_pre_config(c->pool);
     103
    104104    return 1;
    105105}
    106106
Note: See TracBrowser for help on using the repository browser.