Changeset 14a6f41 in mod_gnutls

Timestamp:

Apr 24, 2018, 1:47:16 AM (3 years ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

asyncio, debian/master, master, proxy-ticket

Children:

6c5c2ec

Parents:

de1ceab

Message:

Check for a cache during OCSP setup

File:

• src/gnutls_ocsp.c (modified) (1 diff)

src/gnutls_ocsp.c

@@ -1092 +1092 @@
     mgs_srvconf_rec *sc = (mgs_srvconf_rec *)
         ap_get_module_config(server->module_config, &gnutls_module);
-    // TODO: check for cache!
 
     if (sc->certs_x509_chain_num < 2)
     {
-        ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, server,
+        ap_log_error(APLOG_MARK, APLOG_STARTUP, APR_EINVAL, server,
                      "OCSP stapling is enabled but no CA certificate "
                      "available for %s:%d, make sure it is included in "
                      "GnuTLSCertificateFile!",
                      server->server_hostname, server->addrs->host_port);
+        return HTTP_NOT_FOUND;
+    }
+
+    if (sc->cache == NULL)
+    {
+        ap_log_error(APLOG_MARK, APLOG_STARTUP, APR_EINVAL, server,
+                     "OCSP stapling is enabled but no cache configured!");
         return HTTP_NOT_FOUND;
     }