Changeset 2b1b52f in mod_gnutls


Ignore:
Timestamp:
Jun 5, 2020, 1:51:37 PM (5 months ago)
Author:
Fiona Klute <fiona.klute@…>
Branches:
master
Children:
641d11b
Parents:
cb1d852
Message:

Actually use the computed socache key in socache_delete_session()

We rely on the socache expiration rather than GnuTLS deleting cache
entries, so this function was likely never called, but if it was it
would have failed because it used the raw session ID provided by
GnuTLS rather than the derived key mod_gnutls uses for store and
fetch.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • src/gnutls_cache.c

    rcb1d852 r2b1b52f  
    282282static int socache_delete_session(void *baton, gnutls_datum_t key)
    283283{
    284     gnutls_datum_t tmpkey;
     284    gnutls_datum_t dbmkey;
    285285    mgs_handle_t *ctxt = baton;
    286286
    287     if (mgs_session_id2dbm(ctxt->c, key.data, key.size, &tmpkey) < 0)
     287    if (mgs_session_id2dbm(ctxt->c, key.data, key.size, &dbmkey) < 0)
    288288        return -1;
    289289
     
    292292    apr_status_t rv = ctxt->sc->cache->prov->remove(ctxt->sc->cache->socache,
    293293                                                    ctxt->c->base_server,
    294                                                     key.data, key.size,
     294                                                    dbmkey.data, dbmkey.size,
    295295                                                    ctxt->c->pool);
    296296    if (ctxt->sc->cache->prov->flags & AP_SOCACHE_FLAG_NOTMPSAFE)
Note: See TracChangeset for help on using the changeset viewer.