Changeset 32f2e60 in mod_gnutls for src/gnutls_io.c

Timestamp:

Dec 9, 2004, 2:52:31 AM (15 years ago)

Author:

Paul Querna <chip@…>

Branches:

debian/master, debian/stretch-backports, jessie-backports, master, msva, upstream

Children:

76bd3bf

Parents:

0314deb

Message:

fixes and stuff that i should of already committed.

File:

• src/gnutls_io.c (modified) (5 diffs)

src/gnutls_io.c

@@ -333 +333 @@
 
 
-#define GNUTLS_HANDSHAKE_ATTEMPTS 10
-
 static void gnutls_do_handshake(mod_gnutls_handle_t * ctxt)
 {
-    int i, ret;
+    int ret;
 
     if (ctxt->status != 0)
         return;
-#if 0
-
-    for (i = GNUTLS_HANDSHAKE_ATTEMPTS; i > 0; i--) {
-        ret = gnutls_handshake(ctxt->session);
-        if (ret == GNUTLS_E_INTERRUPTED || ret == GNUTLS_E_AGAIN) {
-            continue;
-        }
-
-        if (ret < 0) {
-            if (ret == GNUTLS_E_WARNING_ALERT_RECEIVED
-                || ret == GNUTLS_E_FATAL_ALERT_RECEIVED) {
-                ret = gnutls_alert_get(ctxt->session);
-                ap_log_error(APLOG_MARK, APLOG_ERR, 0, ctxt->c->base_server,
-                             "GnuTLS: Hanshake Alert (%d) '%s'.\n", ret,
-                             gnutls_alert_get_name(ret));
-            }
-
-            gnutls_deinit(ctxt->session);
-            ap_log_error(APLOG_MARK, APLOG_ERR, 0, ctxt->c->base_server,
-                             "GnuTLS: Handshake Failed (%d) '%s'", ret,
-                             gnutls_strerror(ret));
-                ctxt->status = -1;
-                return;
-        }
-        else {
-            ctxt->status = 1;
-            return;             /* all done with the handshake */
-        }
-    }
-    ctxt->status = -1;
-    return;
-#else
         ret = gnutls_handshake(ctxt->session);
         if (ret < 0) {
@@ -394 +360 @@
             return;             /* all done with the handshake */
         }
-
-#endif
 }
 
@@ -466 +430 @@
                                       apr_bucket_brigade * bb)
 {
-    int ret;
+    apr_size_t ret;
     mod_gnutls_handle_t *ctxt = (mod_gnutls_handle_t *) f->ctx;
     apr_status_t status = APR_SUCCESS;
@@ -514 +478 @@
         }
         else {
-
             /* filter output */
             const char *data;
@@ -547 +510 @@
                 }
             }
-            else if ((apr_size_t) ret != len) {
-                //apr_bucket_split(bucket, ret);
-                //APR_BUCKET_REMOVE(bucket);
-                /* not all of the data was sent. */
-                /* mod_ssl basicly errors out here.. this doesn't seem right? */
-                ap_log_error(APLOG_MARK, APLOG_INFO, ctxt->output_rc,
-                             ctxt->c->base_server,
-                             "GnuTLS: failed to write %" APR_SSIZE_T_FMT
-                             " of %" APR_SIZE_T_FMT " bytes.",
-                             len - (apr_size_t) ret, len);
-                //continue;
-                if (ctxt->output_rc == APR_SUCCESS) {
-                    ctxt->output_rc = APR_EGENERAL;
-                }
+            else if (ret != len) {
+                /* Not able to send the entire bucket, 
+                   split it and send it again. */
+                apr_bucket_split(bucket, ret);
             }