Changeset 5ea6c14 in mod_gnutls

Timestamp:

Jan 5, 2020, 7:10:53 AM (3 years ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

asyncio, main, master, proxy-ticket

Children:

a274959

Parents:

459a982

Message:

Clarify exception message for unexpected headers

Using the representation means the text will include quotes if the
value is a string, but not around None. Also add doctests.

File:

• test/mgstest/tests.py (modified) (2 diffs)

test/mgstest/tests.py

@@ -242 +242 @@
 
     def check_headers(self, headers):
+        """
+        >>> r1 = TestRequest(path='/test.txt',
+        ...                  expect={ 'headers': {'X-Forbidden-Header': None,
+        ...                                       'X-Required-Header': 'Hi!' }})
+        >>> r1.check_headers({ 'X-Required-Header': 'Hi!' })
+        >>> r1.check_headers({ 'X-Required-Header': 'Hello!' })
+        Traceback (most recent call last):
+        ...
+        mgstest.TestExpectationFailed: Unexpected value in header X-Required-Header: 'Hello!', expected 'Hi!'
+        >>> r1.check_headers({ 'X-Forbidden-Header': 'Hi!' })
+        Traceback (most recent call last):
+        ...
+        mgstest.TestExpectationFailed: Unexpected value in header X-Forbidden-Header: 'Hi!', expected None
+        """
         for name, expected in self.expect['headers'].items():
             value = headers.get(name)
@@ -247 +261 @@
             if value != expected:
                 raise TestExpectationFailed(
-                    f'Unexpected value in header {name}: "{value}", '
-                    f'expected "{expected}"')
+                    f'Unexpected value in header {name}: {value!r}, '
+                    f'expected {expected!r}')
 
     def check_body(self, body):