Changeset 8f000b7 in mod_gnutls

Timestamp:

Jun 12, 2020, 5:14:00 PM (4 months ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

master

Children:

8d0efdc

Parents:

2c94b65

Message:

Deprecate SRP and disable it by default

GnuTLS hasn't anounced a schedule yet, but removal is planned unless
the specification is updated, see:
​https://gitlab.com/gnutls/gnutls/-/issues/201

I'm not aware of any use in practice either.

File:

• configure.ac (modified) (2 diffs)

configure.ac

@@ -59 +59 @@
 
 AC_ARG_ENABLE(srp,
-       AS_HELP_STRING([--disable-srp],
-               [unconditionally disable the SRP functionality]),
-       use_srp=$enableval, use_srp=yes)
+       AS_HELP_STRING([--enable-srp],
+               [enable SRP functionality if supported by libgnutls]),
+       use_srp=$enableval, use_srp=no)
 
 # check if the available GnuTLS library supports SRP
 AC_SEARCH_LIBS([gnutls_srp_server_get_username], [gnutls], [], [use_srp="no"])
 
+AC_MSG_CHECKING([whether to enable SRP functionality])
+AC_MSG_RESULT($use_srp)
+
 GNUTLS_FEAT_CFLAGS=""
-if test "$use_srp" != "no"; then
+AS_IF([test "${use_srp}" != "no"], [
         GNUTLS_FEAT_CFLAGS="-DENABLE_SRP=1"
-fi
+        AC_MSG_WARN([You have enabled SRP support. This feature is deprecated and will be removed in a future release.])
+])
 
 AC_ARG_ENABLE(strict,
@@ -80 +84 @@
         STRICT_CFLAGS="-Wall -Werror -Wextra -Wno-error=deprecated-declarations"
 fi
-
-AC_MSG_CHECKING([whether to enable SRP functionality])
-AC_MSG_RESULT($use_srp)
 
 MOD_GNUTLS_DEBUG=0