Changeset 9085f5b in mod_gnutls

Timestamp:

Mar 15, 2010, 4:48:49 PM (10 years ago)

Author:

Nokis Mavrogiannopoulos <nmav@…>

Branches:

debian/master, debian/stretch-backports, jessie-backports, master, msva, upstream

Children:

d02158b

Parents:

dcf1118

git-author:

Nikos Mavrogiannopoulos <nmav@…> (03/15/10 16:48:49)

git-committer:

Nokis Mavrogiannopoulos <nmav@…> (03/15/10 16:48:49)

Message:

Corrected issue with firefox and long post data (had to do
with read function not handling EAGAIN and EINTR correctly).

Files:

• NEWS (modified) (1 diff)
• configure.ac (modified) (1 diff)
• src/gnutls_io.c (modified) (2 diffs)

NEWS

@@ -1 @@
-** Version 0.5.5 (unreleased)
+** Version 0.5.6
+- Corrected issue with firefox and long POST data (by
+  handling EINTR and EAGAIN errors in read).
+
+- Added support for chained client certificates
+
+- Corrected more issues related to double frees
+http://issues.outoforder.cc/view.php?id=102
+
+** Version 0.5.5 (2009-06-13)
 
 - Removed limits on CA certificate loading. Reported by
   Sander Marechal and Jack Bates.
+
+- Do not allow sending empty TLS packets even when instructed to.
+  This had the side effect of clients closing connection.
 
 ** Version 0.5.4 (2009-01-04)

configure.ac

@@ -1 +1 @@
 dnl 
-AC_INIT(mod_gnutls, 0.5.4)
+AC_INIT(mod_gnutls, 0.5.5)
 OOO_CONFIG_NICE(config.nice)
 MOD_GNUTLS_VERSION=AC_PACKAGE_VERSION

src/gnutls_io.c

@@ -671 +671 @@
         if (APR_STATUS_IS_EAGAIN(rc) || APR_STATUS_IS_EINTR(rc)
             || (rc == APR_SUCCESS && APR_BRIGADE_EMPTY(ctxt->input_bb))) {
-            return 0;
-        }
+            
+            if (APR_STATUS_IS_EOF(ctxt->input_rc)) {
+                return 0;
+            } else {
+                gnutls_transport_set_errno(ctxt->session, EINTR);
+                return -1;
+            }
+        }
+        
 
         if (rc != APR_SUCCESS) {
@@ -690 +697 @@
     if (APR_STATUS_IS_EAGAIN(ctxt->input_rc)
         || APR_STATUS_IS_EINTR(ctxt->input_rc)) {
+        if (len == 0) {
+            gnutls_transport_set_errno(ctxt->session, EINTR);
+            return -1;
+        }
+
         return (ssize_t) len;
     }