Changeset 9db4dcd in mod_gnutls for test

Timestamp:

Jan 21, 2020, 3:24:32 PM (23 months ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

asyncio, master, proxy-ticket

Children:

fcad37b

Parents:

4a22ee6

Message:

Handle GNUTLS_E_GOT_APPLICATION_DATA on gnutls_reauth()

Pending application data is cached in the connection input buffer, so
repeated attempts won't cause more memory allocations. If the buffer
is too small HTTP_REQUEST_ENTITY_TOO_LARGE is sent to the client.

The reauthentication test now contains a POST request so this code
path may (!) be taken during the test suite run.

Location:

test

Files:

• Makefile.am (modified) (1 diff)
• data/secret/mirror.cgi (added)
• tests/35_client_reauth/test.yml (modified) (1 diff)

test/Makefile.am

@@ -249 +249 @@
 # Apache configuration and data files
 apache_data = base_apache.conf cgi_module.conf data/dump.cgi data/ocsp.cgi \
-        data/test.txt mime.types proxy_mods.conf
+        data/test.txt data/secret/mirror.cgi data/secret/test.txt \
+        mime.types proxy_mods.conf
 
 # Documentation for the test system

test/tests/35_client_reauth/test.yml

@@ -17 +17 @@
           test
   - !request
-    method: GET
-    path: /secret/test.txt
+    method: POST
+    path: /secret/mirror.cgi
+    body: |
+      GNUTLS_E_GOT_APPLICATION_DATA can (randomly, depending on
+      timing) happen with a request containing a body. According to
+      https://tools.ietf.org/html/rfc8446#appendix-E.1.2
+      post-handshake authentication proves that the authenticated
+      party is the one that did the handshake, so caching the data
+      is appropriate.
     expect:
       status: 200
       body:
         exactly: |
-          top secret
+          GNUTLS_E_GOT_APPLICATION_DATA can (randomly, depending on
+          timing) happen with a request containing a body. According to
+          https://tools.ietf.org/html/rfc8446#appendix-E.1.2
+          post-handshake authentication proves that the authenticated
+          party is the one that did the handshake, so caching the data
+          is appropriate.
   - !request
     method: GET