Changeset b077bdd in mod_gnutls

Timestamp:

Dec 3, 2007, 4:09:43 PM (15 years ago)

Author:

Nokis Mavrogiannopoulos <nmav@…>

Branches:

asyncio, debian/master, debian/stretch-backports, jessie-backports, main, master, msva, proxy-ticket, upstream

Children:

3b83e00

Parents:

8e2a483

git-author:

Nikos Mavrogiannopoulos <nmav@…> (12/03/07 16:09:43)

git-committer:

Nokis Mavrogiannopoulos <nmav@…> (12/03/07 16:09:43)

Message:

added more error checks.

Location:

src

Files:

• gnutls_config.c (modified) (5 diffs)
• gnutls_hooks.c (modified) (2 diffs)

src/gnutls_config.c

@@ -73 +73 @@
     }
 
-    gnutls_dh_params_init(&sc->dh_params);
+    ret = gnutls_dh_params_init(&sc->dh_params);
+    if (ret < 0) {
+        return apr_psprintf(parms->pool, "GnuTLS: Failed to initialize"
+                            ": (%d) %s", ret, gnutls_strerror(ret));
+    }
+
     ret =
         gnutls_dh_params_import_pkcs3(sc->dh_params, &data, GNUTLS_X509_FMT_PEM);
-    if (ret != 0) {
+    if (ret < 0) {
         return apr_psprintf(parms->pool, "GnuTLS: Failed to Import "
                             "DH params '%s': (%d) %s", file, ret,
@@ -108 +113 @@
     }
 
-    gnutls_rsa_params_init(&sc->rsa_params);
+    ret = gnutls_rsa_params_init(&sc->rsa_params);
+    if (ret < 0) {
+        return apr_psprintf(parms->pool, "GnuTLS: Failed to initialize"
+                            ": (%d) %s", ret, gnutls_strerror(ret));
+    }
+
     ret =
         gnutls_rsa_params_import_pkcs1(sc->rsa_params, &data, GNUTLS_X509_FMT_PEM);
@@ -142 +152 @@
     }
 
-    gnutls_x509_crt_init(&sc->cert_x509);
+    ret = gnutls_x509_crt_init(&sc->cert_x509);
+    if (ret < 0) {
+        return apr_psprintf(parms->pool, "GnuTLS: Failed to initialize"
+                            ": (%d) %s", ret, gnutls_strerror(ret));
+    }
+
     ret =
         gnutls_x509_crt_import(sc->cert_x509, &data, GNUTLS_X509_FMT_PEM);
@@ -175 +190 @@
     }
 
-    gnutls_x509_privkey_init(&sc->privkey_x509);
+    ret = gnutls_x509_privkey_init(&sc->privkey_x509);
+    if (ret < 0) {
+        return apr_psprintf(parms->pool, "GnuTLS: Failed to initialize"
+                            ": (%d) %s", ret, gnutls_strerror(ret));
+    }
+
     ret =
         gnutls_x509_privkey_import(sc->privkey_x509, &data,
@@ -396 +416 @@
 {
     mgs_srvconf_rec *sc = apr_pcalloc(p, sizeof(*sc));
-
+    int ret;
+    
     sc->enabled = GNUTLS_ENABLED_FALSE;
 
-    gnutls_certificate_allocate_credentials(&sc->certs);
-    gnutls_anon_allocate_server_credentials(&sc->anon_creds);
-    gnutls_srp_allocate_server_credentials(&sc->srp_creds);
+    ret = gnutls_certificate_allocate_credentials(&sc->certs);
+    if (ret < 0) {
+        return apr_psprintf(p, "GnuTLS: Failed to initialize"
+                            ": (%d) %s", ret, gnutls_strerror(ret));
+    }
+
+    ret = gnutls_anon_allocate_server_credentials(&sc->anon_creds);
+    if (ret < 0) {
+        return apr_psprintf(p, "GnuTLS: Failed to initialize"
+                            ": (%d) %s", ret, gnutls_strerror(ret));
+    }
+
+    ret = gnutls_srp_allocate_server_credentials(&sc->srp_creds);
+    if (ret < 0) {
+        return apr_psprintf(p, "GnuTLS: Failed to initialize"
+                            ": (%d) %s", ret, gnutls_strerror(ret));
+    }
 
     sc->srp_tpasswd_conf_file = NULL;

src/gnutls_hooks.c

@@ -58 +58 @@
                     apr_pool_t * plog, apr_pool_t * ptemp)
 {
+int ret;
 
 #if APR_HAS_THREADS
@@ -68 +69 @@
 #endif
 
-    gnutls_global_init();
-
+    ret = gnutls_global_init();
+    if (ret < 0) /* FIXME: can we print here? */
+        exit(ret);
+                                            
     apr_pool_cleanup_register(pconf, NULL, mgs_cleanup_pre_config,
                               apr_pool_cleanup_null);