Changeset b307cc1 in mod_gnutls

Timestamp:

Jan 7, 2020, 12:50:20 PM (3 years ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

asyncio, main, master, proxy-ticket

Children:

0cfe818

Parents:

a274959

git-author:

Fiona Klute <fiona.klute@…> (01/07/20 02:07:51)

git-committer:

Fiona Klute <fiona.klute@…> (01/07/20 12:50:20)

Message:

mgstest.http._stderr_writer: Always close input stream at EOS

Fixes "ResourceWarning?: unclosed file" after using an
HTTPSubprocessConnection.

File:

• test/mgstest/http.py (modified) (2 diffs)

test/mgstest/http.py

@@ -17 +17 @@
 """HTTP handling components for mod_gnutls tests."""
 
+import contextlib
 import socket
 import subprocess
@@ -122 +123 @@
     synchronization (via global interpreter lock).
 
+    The incoming stream is closed after all lines have been read.
+
     """
-    for line in stream:
-        print(line.decode(), file=sys.stderr, end='', flush=True)
-        if copy:
-            print(line.decode(), file=copy, end='')
+    with contextlib.closing(stream):
+        for line in stream:
+            print(line.decode(), file=sys.stderr, end='', flush=True)
+            if copy:
+                print(line.decode(), file=copy, end='')