Changeset c005645 in mod_gnutls for include

Timestamp:

Jun 8, 2016, 3:31:29 PM (6 years ago)

Author:

Thomas Klute <thomas2.klute@…>

Branches:

asyncio, debian/master, debian/stretch-backports, master, proxy-ticket, upstream

Children:

c55902b

Parents:

eb63377

Message:

Mutex for DBM cache access

I noticed that with a DBM cache enabled and session tickets disabled
even a handful of parallel connections trashed the cache database, and
consequently the error log. According to comments and documentation on
mod_socache_dbm the APR DBM module is not thread or multi-process
safe, so a global mutex is necessary. With the mutex the cache
corruption disappears in my benchmarks.

File:

• include/mod_gnutls.h.in (modified) (1 diff)

include/mod_gnutls.h.in

@@ -133 +133 @@
     mgs_cache_e cache_type;
     const char* cache_config;
+    /* Mutex for cache access (used only if the cache type is not
+     * thread-safe) */
+    apr_global_mutex_t *cache_mutex;
 
         /* GnuTLS uses Session Tickets */