Changeset cb5188f in mod_gnutls

Timestamp:

Jan 29, 2013, 8:05:42 PM (7 years ago)

Author:

Daniel Kahn Gillmor <dkg@…>

Branches:

debian/master, debian/stretch-backports, jessie-backports, master, msva, upstream

Children:

932b68e

Parents:

421ef1c

git-author:

Daniel Kahn Gillmor <dkg@…> (01/28/13 23:20:10)

git-committer:

Daniel Kahn Gillmor <dkg@…> (01/29/13 20:05:42)

Message:

fatal library initialization error logs should be at APLOG_EMERG

http_log.h describes APLOG_EMERG as "system is unusable", which is
much more appropriate for failures to initialize a critical library
than APLOG_DEBUG.

File:

• src/gnutls_hooks.c (modified) (3 diffs)

src/gnutls_hooks.c

@@ -76 +76 @@
         /* Check for required GnuTLS Library Version */
     if (gnutls_check_version(req_GnuTLSVer) == NULL) {
-                ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, plog, "gnutls_check_version() failed. Required: "
+                ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, plog, "gnutls_check_version() failed. Required: "
                                         "gnutls-%s Found: gnutls-%s\n", LIBGNUTLS_VERSION, gnutls_check_version(NULL));
         return DONE;
@@ -84 +84 @@
     ret = gnutls_global_init();
     if (ret < 0) {
-                ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, plog, "gnutls_global_init: %s\n", gnutls_strerror(ret));
+                ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, plog, "gnutls_global_init: %s\n", gnutls_strerror(ret));
                 return DONE;
     }
@@ -91 +91 @@
     ret = gnutls_session_ticket_key_generate(&session_ticket_key);
     if (ret < 0) {
-                ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, plog, "gnutls_session_ticket_key_generate: %s\n", gnutls_strerror(ret));
+                ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, plog, "gnutls_session_ticket_key_generate: %s\n", gnutls_strerror(ret));
                 return DONE;
     }