Changeset cb5188f in mod_gnutls


Ignore:
Timestamp:
Jan 29, 2013, 8:05:42 PM (7 years ago)
Author:
Daniel Kahn Gillmor <dkg@…>
Branches:
debian/master, debian/stretch-backports, jessie-backports, master, msva, upstream
Children:
932b68e
Parents:
421ef1c
git-author:
Daniel Kahn Gillmor <dkg@…> (01/28/13 23:20:10)
git-committer:
Daniel Kahn Gillmor <dkg@…> (01/29/13 20:05:42)
Message:

fatal library initialization error logs should be at APLOG_EMERG

http_log.h describes APLOG_EMERG as "system is unusable", which is
much more appropriate for failures to initialize a critical library
than APLOG_DEBUG.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • src/gnutls_hooks.c

    r421ef1c rcb5188f  
    7676        /* Check for required GnuTLS Library Version */
    7777    if (gnutls_check_version(req_GnuTLSVer) == NULL) {
    78                 ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, plog, "gnutls_check_version() failed. Required: "
     78                ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, plog, "gnutls_check_version() failed. Required: "
    7979                                        "gnutls-%s Found: gnutls-%s\n", LIBGNUTLS_VERSION, gnutls_check_version(NULL));
    8080        return DONE;
     
    8484    ret = gnutls_global_init();
    8585    if (ret < 0) {
    86                 ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, plog, "gnutls_global_init: %s\n", gnutls_strerror(ret));
     86                ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, plog, "gnutls_global_init: %s\n", gnutls_strerror(ret));
    8787                return DONE;
    8888    }
     
    9191    ret = gnutls_session_ticket_key_generate(&session_ticket_key);
    9292    if (ret < 0) {
    93                 ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, plog, "gnutls_session_ticket_key_generate: %s\n", gnutls_strerror(ret));
     93                ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, plog, "gnutls_session_ticket_key_generate: %s\n", gnutls_strerror(ret));
    9494                return DONE;
    9595    }
Note: See TracChangeset for help on using the changeset viewer.