Changeset dcec209 in mod_gnutls


Ignore:
Timestamp:
Nov 28, 2019, 6:22:08 AM (8 days ago)
Author:
Fiona Klute <fiona.klute@…>
Branches:
master
Children:
d4c9331
Parents:
f064d74
git-author:
Fiona Klute <fiona.klute@…> (11/28/19 04:42:46)
git-committer:
Fiona Klute <fiona.klute@…> (11/28/19 06:22:08)
Message:

Fix possible segfault (NULL pointer dereference) on failed TLS handshake

Calling ssl_var_lookup() after a failed handshake could lead to GnuTLS
session information functions being called on a NULL session pointer,
leading to segfault. I observed this in a case where mod_http2 was
trying to check the negotiated TLS version after the client rejected
the server certificate.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • src/mod_gnutls.c

    rf064d74 rdcec209  
    33 *  Copyright 2008, 2014 Nikos Mavrogiannopoulos
    44 *  Copyright 2011 Dash Shendy
    5  *  Copyright 2015-2018 Fiona Klute
     5 *  Copyright 2015-2019 Fiona Klute
    66 *
    77 *  Licensed under the Apache License, Version 2.0 (the "License");
     
    179179
    180180    /* TLS parameters are empty if there is no session */
    181     if (ctxt == NULL || ctxt->c == NULL)
     181    if (ctxt == NULL || ctxt->c == NULL || ctxt->session == NULL)
    182182        return NULL;
    183183
Note: See TracChangeset for help on using the changeset viewer.