Changeset dcec209 in mod_gnutls for src/mod_gnutls.c

Timestamp:

Nov 28, 2019, 6:22:08 AM (3 years ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

asyncio, master, proxy-ticket

Children:

d4c9331

Parents:

f064d74

git-author:

Fiona Klute <fiona.klute@…> (11/28/19 04:42:46)

git-committer:

Fiona Klute <fiona.klute@…> (11/28/19 06:22:08)

Message:

Fix possible segfault (NULL pointer dereference) on failed TLS handshake

Calling ssl_var_lookup() after a failed handshake could lead to GnuTLS
session information functions being called on a NULL session pointer,
leading to segfault. I observed this in a case where mod_http2 was
trying to check the negotiated TLS version after the client rejected
the server certificate.

File:

• src/mod_gnutls.c (modified) (2 diffs)

src/mod_gnutls.c

@@ -3 +3 @@
  *  Copyright 2008, 2014 Nikos Mavrogiannopoulos
  *  Copyright 2011 Dash Shendy
- *  Copyright 2015-2018 Fiona Klute
+ *  Copyright 2015-2019 Fiona Klute
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
@@ -179 +179 @@
 
     /* TLS parameters are empty if there is no session */
-    if (ctxt == NULL || ctxt->c == NULL)
+    if (ctxt == NULL || ctxt->c == NULL || ctxt->session == NULL)
         return NULL;