Changeset e6d9e47 in mod_gnutls

Timestamp:

Jun 5, 2020, 3:42:56 PM (8 months ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

asyncio, master

Children:

796d9a3

Parents:

641d11b

Message:

Move the callback for incoming tickets into gnutls_proxy.c

It's only used for proxy connection, so that's the appropriate
location.

Location:

src

Files:

• gnutls_hooks.c (modified) (2 diffs)
• gnutls_proxy.c (modified) (1 diff)
• gnutls_proxy.h (modified) (1 diff)

src/gnutls_hooks.c

@@ -1130 +1130 @@
 }
 
-static int got_ticket_func(gnutls_session_t session,
-                           unsigned int htype,
-                           unsigned when,
-                           unsigned int incoming __attribute__((unused)),
-                           const gnutls_datum_t *msg __attribute__((unused)))
-{
-    /* Ignore all unexpected messages */
-    if (htype != GNUTLS_HANDSHAKE_NEW_SESSION_TICKET
-        || when != GNUTLS_HOOK_POST)
-        return GNUTLS_E_SUCCESS;
-
-    mgs_handle_t *ctxt = gnutls_session_get_ptr(session);
-    if (!(gnutls_session_get_flags(session) & GNUTLS_SFLAGS_SESSION_TICKET))
-    {
-        ap_log_cerror(APLOG_MARK, APLOG_WARNING, APR_SUCCESS, ctxt->c,
-                      "%s called but session has no ticket!",
-                      __func__);
-        /* Tickets are optional, so don't break the session on
-         * errors. */
-        return GNUTLS_E_SUCCESS;
-    }
-
-    /* No cache means we cannot cache tickets. */
-    if (!ctxt->sc->cache_enable)
-        return GNUTLS_E_SUCCESS;
-
-    gnutls_datum_t ticket;
-    int ret = gnutls_session_get_data2(session, &ticket);
-    if (ret != GNUTLS_E_SUCCESS)
-    {
-        ap_log_cerror(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, ctxt->c,
-                      "%s: error reading session ticket: %s (%d)",
-                      __func__, gnutls_strerror(ret), ret);
-        if (ticket.data)
-            gnutls_free(ticket.data);
-        return GNUTLS_E_SUCCESS;
-    }
-
-    apr_time_t expiry = apr_time_now() + ctxt->sc->cache_timeout;
-    ap_log_cerror(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, ctxt->c,
-                  "%s: caching session ticket for %s (%u bytes)",
-                  __func__, ctxt->proxy_ticket_key.data, ticket.size);
-    mgs_cache_store(ctxt->sc->cache, ctxt->c->base_server,
-                    ctxt->proxy_ticket_key, ticket, expiry);
-    gnutls_free(ticket.data);
-    return GNUTLS_E_SUCCESS;
-}
-
 static void create_gnutls_handle(conn_rec * c)
 {
@@ -1206 +1158 @@
         gnutls_handshake_set_hook_function(ctxt->session,
                                            GNUTLS_HANDSHAKE_NEW_SESSION_TICKET,
-                                           GNUTLS_HOOK_POST, got_ticket_func);
+                                           GNUTLS_HOOK_POST,
+                                           mgs_proxy_got_ticket_func);
         ctxt->proxy_ticket_key = mgs_proxy_ticket_id(ctxt, NULL);
     }

src/gnutls_proxy.c

@@ -297 +297 @@
 
 
+int mgs_proxy_got_ticket_func(gnutls_session_t session,
+                              unsigned int htype,
+                              unsigned when,
+                              unsigned int incoming __attribute__((unused)),
+                              const gnutls_datum_t *msg __attribute__((unused)))
+{
+    /* Ignore all unexpected messages */
+    if (htype != GNUTLS_HANDSHAKE_NEW_SESSION_TICKET
+        || when != GNUTLS_HOOK_POST)
+        return GNUTLS_E_SUCCESS;
+
+    mgs_handle_t *ctxt = gnutls_session_get_ptr(session);
+    if (!(gnutls_session_get_flags(session) & GNUTLS_SFLAGS_SESSION_TICKET))
+    {
+        ap_log_cerror(APLOG_MARK, APLOG_WARNING, APR_SUCCESS, ctxt->c,
+                      "%s called but session has no ticket!",
+                      __func__);
+        /* Tickets are optional, so don't break the session on
+         * errors. */
+        return GNUTLS_E_SUCCESS;
+    }
+
+    /* No cache means we cannot cache tickets. */
+    if (!ctxt->sc->cache_enable)
+        return GNUTLS_E_SUCCESS;
+
+    gnutls_datum_t ticket;
+    int ret = gnutls_session_get_data2(session, &ticket);
+    if (ret != GNUTLS_E_SUCCESS)
+    {
+        ap_log_cerror(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, ctxt->c,
+                      "%s: error reading session ticket: %s (%d)",
+                      __func__, gnutls_strerror(ret), ret);
+        if (ticket.data)
+            gnutls_free(ticket.data);
+        return GNUTLS_E_SUCCESS;
+    }
+
+    apr_time_t expiry = apr_time_now() + ctxt->sc->cache_timeout;
+    ap_log_cerror(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, ctxt->c,
+                  "%s: caching session ticket for %s (%u bytes)",
+                  __func__, ctxt->proxy_ticket_key.data, ticket.size);
+    mgs_cache_store(ctxt->sc->cache, ctxt->c->base_server,
+                    ctxt->proxy_ticket_key, ticket, expiry);
+    gnutls_free(ticket.data);
+    return GNUTLS_E_SUCCESS;
+}
+
+
+
 /**
  * Returns either a valid hostname for use with SNI, or NULL.

src/gnutls_proxy.h

@@ -55 +55 @@
 gnutls_datum_t mgs_proxy_ticket_id(mgs_handle_t *ctxt, apr_pool_t *pool);
 
+/**
+ * `gnutls_handshake_hook_func` to handle incoming session tickets on
+ * proxy connections.
+ */
+int mgs_proxy_got_ticket_func(gnutls_session_t session,
+                              unsigned int htype,
+                              unsigned when,
+                              unsigned int incoming __attribute__((unused)),
+                              const gnutls_datum_t *msg __attribute__((unused)));
+
 #endif /* __MOD_GNUTLS_PROXY_H__ */