Changeset efc43b4 in mod_gnutls for src/gnutls_ocsp.h

Timestamp:

Sep 25, 2018, 3:46:26 PM (2 years ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

asyncio, debian/master, master, proxy-ticket

Children:

cb6476c

Parents:

994200a

Message:

Split per-vhost post config for OCSP stapling into configuring and enabling

This is preparation for enabling stapling by default: Configuration
failure may be ignored if stapling is not explicitly enabled by the
user (at the cost of not stapling).

File:

• src/gnutls_ocsp.h (modified) (1 diff)

src/gnutls_ocsp.h

@@ -98 +98 @@
 
 /**
- * Initialize server config for OCSP, supposed to be called in the
- * post_config hook for each server where OCSP stapling is enabled,
- * after certificates have been loaded.
+ * Try to generate the OCSP stapling configuration for a (virtual)
+ * host. This function must be called in the post_config hook after
+ * certificates have been loaded. This method does not actually enable
+ * stapling, it only prepares the configuration. The reason for
+ * splitting these tasks is that configuration failure may be ignored
+ * if stapling is not explicitly enabled but only opportunistically.
+ *
+ * @return `NULL` on success, a string describing why configuration
+ * failed otherwise (static or allocated from ptemp)
+ */
+const char* mgs_ocsp_configure_stapling(apr_pool_t *pconf, apr_pool_t *ptemp,
+                                        server_rec *server);
+
+/**
+ * Enable OCSP stapling for a (virtual) host. Must be called in the
+ * post_config hook after mgs_ocsp_configure_stapling has returned
+ * successfully for that host.
  *
  * @return OK or DECLINED on success, any other value on error (like
- * the post_config hook itself)
+ * the post_config hook)
  */
-int mgs_ocsp_post_config_server(apr_pool_t *pconf, apr_pool_t *ptemp,
-                                server_rec *server);
+int mgs_ocsp_enable_stapling(apr_pool_t *pconf, apr_pool_t *ptemp,
+                             server_rec *server);
 
 int mgs_get_ocsp_response(gnutls_session_t session, void *ptr,