Changeset f6d2721 in mod_gnutls

Timestamp:

Dec 6, 2019, 11:28:23 AM (18 months ago)

Author:

Fiona Klute <fiona.klute@…>

Branches:

asyncio, master, proxy-ticket

Children:

d762813

Parents:

0560bb9

Message:

HTTPSubprocessConnection: Run filter in a thread instead of process

This is a minor performance improvement in this use case (I
measured). Filter and HTTP processing can't really run in parallel,
because the latter needs the output of the former.

File:

• test/mgstest/http.py (modified) (4 diffs)

test/mgstest/http.py

@@ -21 +21 @@
 
 from http.client import HTTPConnection
-from multiprocessing import Process
+from threading import Thread
 
 class HTTPSubprocessConnection(HTTPConnection):
@@ -50 +50 @@
         # and the socket back to the HTTP connection (write-only).
         self._output_filter = output_filter
-        # output filter process
-        self._fproc = None
+        # output filter thread
+        self._fthread = None
 
     def connect(self):
@@ -63 +63 @@
                                            stdin=s_remote, close_fds=True,
                                            bufsize=0)
-            self._fproc = Process(target=self._output_filter,
-                                  args=(self._sproc.stdout, s_remote))
-            self._fproc.start()
+            self._fthread = Thread(target=self._output_filter,
+                                   args=(self._sproc.stdout, s_remote))
+            self._fthread.start()
         else:
             self._sproc = subprocess.Popen(self.command, stdout=s_remote,
                                            stdin=s_remote, close_fds=True,
                                            bufsize=0)
-        s_remote.close()
         self.sock = s_local
 
@@ -91 +90 @@
                     self.returncode = self._sproc.wait(self.timeout)
 
-        # filter process receives HUP on pipe when the subprocess
+        # filter thread receives HUP on pipe when the subprocess
         # terminates
-        if self._fproc:
-            self._fproc.join()
+        if self._fthread:
+            self._fthread.join()
 
         # close the connection in the super class, which also calls